Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MaxResults when listing objects #1824

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

gaul
Copy link
Contributor

@gaul gaul commented Nov 25, 2024

No description provided.

@gaul
Copy link
Contributor Author

gaul commented Nov 26, 2024

Maybe I missed something but I don't see a way to test this. Does the Go GCS API lack support for setting MaxResults?

Copy link
Owner

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to skip a test here.

Thank you very much for contributing!

@fsouza fsouza merged commit 75e9d81 into fsouza:main Jan 4, 2025
38 checks passed
@gaul gaul deleted the list/max-results branch January 4, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants